Skip to content

Conversation

@atriolo
Copy link
Contributor

@atriolo atriolo commented Jan 19, 2026

Added the possibility to use a version of the response file locally stored when performing digitization.
To be used during digitization studies.
Usage:
o2-sim-digitizer-workflow --local-response-file "path_to_file/ResponseData.root"
If the --local-response-file argument is not set, the response is retrieved from CCDB (as set with PR #14902)

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@atriolo
Copy link
Contributor Author

atriolo commented Jan 22, 2026

Hello @njacazio, @sawenzel, @shahor02, could you please review this PR? Thanks!

shahor02
shahor02 previously approved these changes Jan 22, 2026
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

if (!file) {
LOG(fatal) << "Cannot open response file " << mLocalRespFile;
}
mDigitizer.getParams().setAlpSimResponse((const o2::itsmft::AlpideSimResponse*)file->Get("response1"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical, but better to do file->Close(); delete file;, or open it as std::unique_ptr<TFile>(TFile::Open(mLocalRespFile.data()));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the correction, I had overlooked this point. Now it's fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants